-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[procesor/groupbyattrsprocessor]: fix droping metadata when processing metrics #33781
Merged
evan-bradley
merged 3 commits into
open-telemetry:main
from
odubajDT:fix-metrics-metadata
Jul 15, 2024
Merged
[procesor/groupbyattrsprocessor]: fix droping metadata when processing metrics #33781
evan-bradley
merged 3 commits into
open-telemetry:main
from
odubajDT:fix-metrics-metadata
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/groupbyattrs
Group By Attributes processor
label
Jun 26, 2024
odubajDT
changed the title
[procesor/groupbyattrsprocessor]: fix droping metadata when copying metrics
[procesor/groupbyattrsprocessor]: fix droping metadata when processing metrics
Jun 27, 2024
odubajDT
force-pushed
the
fix-metrics-metadata
branch
from
June 27, 2024 06:39
c7ca9cb
to
7766cee
Compare
dashpole
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@rnishtala-sumo could you take a look as the code owner of this component? |
minor nit, LGTM otherwise. |
rnishtala-sumo
approved these changes
Jul 1, 2024
odubajDT
force-pushed
the
fix-metrics-metadata
branch
2 times, most recently
from
July 2, 2024 07:04
04dc281
to
df57a54
Compare
…etrics Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
fix-metrics-metadata
branch
from
July 15, 2024 05:10
9184af2
to
377714c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes the metadata dropping when processing metrics
Link to tracking Issue: #33419
Testing: