-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/kafka] change topic configuration for consistency with default behavior #33915
[receiver/kafka] change topic configuration for consistency with default behavior #33915
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Interesting. Can we keep the topic field and deprecate it first? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
b686a2e
to
ed98bc7
Compare
@atoulme I applied your suggestion:
LMK if that's ok for you |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description: The parameter
topic
is replaced by three parameterstraces_topic
,metrics_topic
, andlogs_topics
. This change is consistent with the otlp receiver which providestraces_url_path
,metrics_url_path
, andlogs_url_path
parameters.Previously it was not possible to use the same receiver config in different signal pipelines unless the topics were named according to the default values. With this change, the same config can be used in different pipelines because a topic can be specified for each signal.
Link to tracking Issue: #32735
Testing: Existing tests have been updated + local test with docker containers
Documentation: Updated to reflect the config changes