Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kafka] change topic configuration for consistency with default behavior #33915

Closed

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Jul 4, 2024

Description: The parameter topic is replaced by three parameters traces_topic, metrics_topic, and logs_topics. This change is consistent with the otlp receiver which provides traces_url_path, metrics_url_path, and logs_url_path parameters.

Previously it was not possible to use the same receiver config in different signal pipelines unless the topics were named according to the default values. With this change, the same config can be used in different pipelines because a topic can be specified for each signal.

Link to tracking Issue: #32735

Testing: Existing tests have been updated + local test with docker containers

Documentation: Updated to reflect the config changes

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 19, 2024
@atoulme
Copy link
Contributor

atoulme commented Aug 1, 2024

Interesting. Can we keep the topic field and deprecate it first?

@github-actions github-actions bot removed the Stale label Aug 2, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 16, 2024
@wildum wildum force-pushed the kafka-receiver-topic-per-signal branch from b686a2e to ed98bc7 Compare August 19, 2024 10:50
@wildum
Copy link
Contributor Author

wildum commented Aug 19, 2024

@atoulme I applied your suggestion:

  • users that set the field "topic" will get a deprecation warning (but it still works as before)
  • users who did not set the "topic" field explicitly (who are relying on the default values) will not have to do anything (seamless transition)
  • trying to set both the field "topic" and the new "*_topic" fields results in a config error

LMK if that's ok for you

@github-actions github-actions bot removed the Stale label Aug 20, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 3, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants