[exporter/datadog] Deprecate logs::dump_payloads
#34490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liustanley
changed the title
logs::dump_payloads
songy23
reviewed
Aug 7, 2024
songy23
approved these changes
Aug 7, 2024
Co-authored-by: Yang Song <[email protected]>
dineshg13
approved these changes
Aug 8, 2024
mx-psi
approved these changes
Aug 8, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Deprecates `logs::dump_payloads` because this config option is invalid with the Datadog Agent logs pipeline which will be enabled by default in the following release. This PR will be included in v0.107.0 and open-telemetry#34420 will be included in v0.108.0. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> The log appears as follows: ``` 2024-08-07T14:49:10.514-0400 warn [email protected]/config.go:462 logs::dump_payloads is deprecated and will raise an error if set when the Datadog Agent logs pipeline is enabled by default in collector version v0.108.0 {"kind": "exporter", "data_type": "logs", "name": "datadog"} ``` **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecates
logs::dump_payloadsbecause this config option is invalid with the Datadog Agent logs pipeline which will be enabled by default in the following release. This PR will be included in v0.107.0 and #34420 will be included in v0.108.0.Link to tracking Issue:
Testing:
The log appears as follows:
Documentation: