Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix flakiness of tests on Windows requiring ports in the dynamic range #35061

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Sep 6, 2024

Description:
The need for this was noticed due to the following CI failures on the receiver/opencensus lifecycle tests:

The default port used by the opencensusreceiver is in a range that Windows machines can excluded, or reserved to other services via the WinNAT service. This change adds a PowerShell script to release the default ports for the opencensusreceiver (55678) and the zpagesextension (55679) on the Windows GH workflows. While this was affecting only the opencensusreceiver at this time, the cost of running this script is small, less than 5s, and later we can easly add other ports if the need arrives. This was already added to the core repo via open-telemetry/opentelemetry-collector#10839

Link to tracking Issue:
N/A

Testing:
CI

Documentation:
N/A

@pjanotti pjanotti requested review from a team and dmitryax September 6, 2024 22:10
@crobert-1 crobert-1 added the Run Windows Enable running windows test on a PR label Sep 6, 2024
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@mx-psi mx-psi merged commit 248b8ec into open-telemetry:main Sep 9, 2024
171 of 172 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 9, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
…mic range (open-telemetry#35061)

**Description:**
The need for this was noticed due to the following CI failures on the
`receiver/opencensus` lifecycle tests:

*
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10723100311/job/29735640887#step:6:619
*
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10725662745/job/29744029983#step:6:318

The default port used by the `opencensusreceiver` is in a range that
Windows machines can excluded, or reserved to other services via the
`WinNAT` service. This change adds a PowerShell script to release the
default ports for the `opencensusreceiver` (55678) and the
`zpagesextension` (55679) on the Windows GH workflows. While this was
affecting only the `opencensusreceiver` at this time, the cost of
running this script is small, less than 5s, and later we can easly add
other ports if the need arrives. This was already added to the core repo
via open-telemetry/opentelemetry-collector#10839

**Link to tracking Issue:**
N/A

**Testing:**
CI

**Documentation:**
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants