[processor/k8sattributes] Support name:tag@digest image name format #36145
Conversation
github-actions
bot
requested review from
dmitryax,
fatsheep9146 and
TylerHelmuth
spiffyy99
force-pushed
the
fix-k8s-image-parsing
branch
2 times, most recently
from
8a9c1bd
to
90d3a08
Compare
spiffyy99
force-pushed
the
fix-k8s-image-parsing
branch
4 times, most recently
from
09323ed
to
828a728
Compare
There was a problem hiding this comment.
Thank's for working on this @spiffyy99!
I think the fix is in the right direction but I left some concerns.
|
thanks for the review christos. |
There was a problem hiding this comment.
Overall looks good. Could we add a section in the docs describing the logic from https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/36145/files#r1832085419?
Already referenced it here: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/36145/files#diff-f9652f665e3a05f0768f863df6d7543c56b7cf671e4d2be1d7086c5d73e7cc3dR12 any other section you think it would be good to mention this? |
spiffyy99
force-pushed
the
fix-k8s-image-parsing
branch
from
a51981f
to
6b95457
Compare
| @@ -4,33 +4,33 @@ | |||
|
|
|||
| ## Resource Attributes | |||
|
|
|||
| | Name | Description | Values | Enabled | | |||
| | ---- | ----------- | ------ | ------- | | |||
| | Name | Description | Values | Enabled | | |||
There was a problem hiding this comment.
That file is automatically generated by the metadata.yaml. Please apply the edits at
make generate to update the documentation.md properly.
spiffyy99
force-pushed
the
fix-k8s-image-parsing
branch
from
6b95457
to
3859c70
Compare
spiffyy99
force-pushed
the
fix-k8s-image-parsing
branch
from
e09c207
to
25d7678
Compare
spiffyy99
force-pushed
the
fix-k8s-image-parsing
branch
from
d9ee59f
to
35b2a0b
Compare
|
@dmitryax @fatsheep9146 @TylerHelmuth could one of you take a look at this? thanks! |
| // parseAttributesFromImage parses the image name and tag for differently-formatted image names. | ||
| // returns "latest" as the default if tag not present. also checks if the image contains a digest. | ||
| // if it does, no latest tag is assumed. | ||
| func parseNameAndTagFromImage(image string) (name, tag string, err error) { |
There was a problem hiding this comment.
Should we use the already available internal docker.ParseImageName function instead?
I would prefer to all components use the same strategy for common functionalities. Note that the shared function cannot parse images with digest at the moment and should be fixed beforehand: #36279
There was a problem hiding this comment.
Having a single implementation makes sense.
Also I think the package should be renamed to container and not docker since it doesn't only cover docker.
Description
Fixed issue with
k8sattributesprocessorwhere digest is not properly separated from tag if both are present. used official docker library to perform parsing.Link to tracking issue
Fixes #36131
Testing
unit tests
integration/e2e tests
Documentation
N/A. Fields are already described correctly, this is simply fixing parsing logic