influxdbexporter and influxdbreceiver: update #4277
Conversation
|
@jacobmarble I know you were the initial contributor of this repo, but we want to have some "code owners" for this project, can you and maybe a teammate or somebody else maintain this? That mean I need you to create a PR and add to owners to the CODEOWNERS file for this module, so I can ask you folks to review initially :) |
|
@8none1 please review |
Done, I think: #4284 (review) |
|
@8none1 nice try :) Please review this PR since you are an owner :) |
|
(Rebased to resolve conflict) |
|
I tried to review this PR yesterday, but it wouldn't let me. I expect that the CODEOWNERS changes hadn't propagated or something. Works now though. |
| // Options: | ||
| // - telegraf-prometheus-v1 | ||
| // - telegraf-prometheus-v2 | ||
| MetricsSchema string `mapstructure:"metrics_schema"` |
There was a problem hiding this comment.
I know we are still allowed to make breaking changes, but you could have been nicer to your users and deprecating this option first, leaving a big warning in the logs in case this is being used. And effectively remove it in a couple of releases.
jpkrohling
changed the title
Signed-off-by: Bogdan Drutu <[email protected]>
Description:
Updates dependencies github.com/influxdata/influxdb-observability and github.com/influxdata/line-protocol. This changes the way that protobufs are handled, such that they do not need to be serialized and deserialized on every request.
The
pdatapackage was made public here: #3104Smaller, incremental changes are also included in this update, for example, handling untyped line protocol is more robust now.
Testing:
None.
Documentation:
The documentation for influxdbreceiver was updated to not require parameter
metrics_schema