Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/postgresql] Fix unit field in metadata.yaml #6469

Merged
merged 1 commit into from
Dec 1, 2021
Merged

[receiver/postgresql] Fix unit field in metadata.yaml #6469

merged 1 commit into from
Dec 1, 2021

Conversation

dmitryax
Copy link
Member

No description provided.

@dmitryax dmitryax requested a review from a team November 30, 2021 22:45
@dmitryax dmitryax mentioned this pull request Nov 30, 2021
Merged
@bogdandrutu
Copy link
Member

@dmitryax the unittest failure is actually a real failure, see:

=== RUN   TestScraper
    scraper_test.go:45: 
        	Error Trace:	scraper_test.go:45
        	Error:      	Received unexpected error:
        	            	metric Unit does not match expected: , actual: 1
        	Test:       	TestScraper
--- FAIL: TestScraper (0.08s)
=== RUN   TestScraperNoDatabaseSingle
    scraper_test.go:63: 
        	Error Trace:	scraper_test.go:63
        	Error:      	Received unexpected error:
        	            	metric Unit does not match expected: , actual: 1
        	Test:       	TestScraperNoDatabaseSingle
--- FAIL: TestScraperNoDatabaseSingle (0.08s)
=== RUN   TestScraperNoDatabaseMultiple
    scraper_test.go:81: 
        	Error Trace:	scraper_test.go:81
        	Error:      	Received unexpected error:
        	            	metric Unit does not match expected: , actual: 1
        	Test:       	TestScraperNoDatabaseMultiple

codeboten
codeboten approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying @dmitryax!

@bogdandrutu bogdandrutu merged commit 2d059f2 into open-telemetry:main Dec 1, 2021
@dmitryax dmitryax deleted the postgres-fix-metadata-yaml branch December 1, 2021 02:15
jamesmoessis pushed a commit to atlassian-forks/opentelemetry-collector-contrib that referenced this pull request Dec 8, 2021
@dmitryax @jamesmoessis
[receiver/postgresql] Fix unit field in metadata.yaml (open-telemetry…
3fc7f0b 
…#6469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@codeboten codeboten codeboten approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitryax @bogdandrutu @codeboten