Use google cloud collector exporter, and feature-gate pdata-direct metrics exporter. #7177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
rewrite-googlecloud-exporter
branch
from
8ccc05f
to
aeef4c0
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dashpole
force-pushed
the
rewrite-googlecloud-exporter
branch
2 times, most recently
from
3993cb3
to
345067f
Compare
|
Discussed at the sig meeting today. We can move forward with this before pdata is 1.0 |
dashpole
force-pushed
the
rewrite-googlecloud-exporter
branch
8 times, most recently
from
0d7316e
to
c57ad0d
Compare
dashpole
requested review from
jsuereth,
punya and
jpkrohling
as code owners
dashpole
commented
Feb 18, 2022
|
This is ready for review. |
dashpole
force-pushed
the
rewrite-googlecloud-exporter
branch
from
c57ad0d
to
8fb7f1b
Compare
jsuereth
approved these changes
Feb 23, 2022
dashpole
force-pushed
the
rewrite-googlecloud-exporter
branch
4 times, most recently
from
9569652
to
b4a344a
Compare
|
@djaglowski @jpkrohling let me know if there is anything I can do to help make reviews easier. |
|
@open-telemetry/collector-contrib-approvers, could one of you review this one? I don't think I can review this over the next few days. |
mx-psi
approved these changes
Mar 3, 2022
|
There are a bunch of conflicts which you should fix, but otherwise LGTM |
dashpole
force-pushed
the
rewrite-googlecloud-exporter
branch
from
b4a344a
to
8e3a6a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #7132
This changes the googlecloud exporter to use the newly developed GCP collector exporter in the github.com/GoogleCloudPlatform/opentelemetry-operations-go repository. The googlecloud collector exporter lives in that repository so that e2e tests can be run against live google cloud APIs at presubmit time.
Changes are gated by the
exporter.googlecloud.OTLPDirectfeature-gate. This feature will initially be alpha while we iron out any bugs we find.Factory changes and feature-gating
The feature-gate applies to the factory so that the feature-gate also changes which config structure is valid. There are breaking changes across client options. The feature gate also changes which implementation of the metrics and traces exporter is used.
Trace exporter
The only difference between the new vs old trace exporter is configuration (see feature-gate section above); it is unchanged otherwise.
Metric exporter
The metrics exporter is completely re-written, and converts directly from pdata to google cloud's types. Since this is a new implementation, leave the previous implementation in-place in this repository, but prefix files with legacy as a reminder that they should be removed when the feature is graduated to GA. The new metrics implementation is only used when the feature gate is enabled.
Dependencies
The collector exporter is designed specifically to minimize its dependencies on collector-core. It does this by not implementing the component interfaces (e.g.
NewFactory()), and does not depend on component types (e.g.component.ExporterCreateSettings). Thus, it must define its ownConfig, which is the portion of the overallConfigwhich does not include component types. The remaining code here opentelemetry-collector-contrib is just a wrapper around theConfigof the GCP collector exporter which adds exporterhelper pieces, and implements the required collector interfaces.The only dependencies the GCP collector exporter has on collector core are:
go.opentelemetry.io/collector/model/pdatago.opentelemetry.io/collector/model/semconv/v1.8.0