Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/prometheusremotewrite] hookup WAL #7304

Merged
merged 39 commits into from
Mar 7, 2022
Merged

[exporter/prometheusremotewrite] hookup WAL #7304

merged 39 commits into from
Mar 7, 2022

Commits on Sep 11, 2021

  1. exporter/prometheusremotewrite: glue up and use Write-Ahead-Log 

    This change completes the WAL capability for the Prometheus Remote-Write exporter
that allows recovery of data if the prior write requests weren't yet exported.

This wires up a Write-Ahead-Log (WAL) that was implemented in
PR open-telemetry/opentelemetry-collector#3597, which
was split off from PR open-telemetry/opentelemetry-collector#3017.

Note: there is very rare condition for which we can perhaps send the
same data a couple of times, and it can happen if we haven't yet truncated
the WAL, the RemoteWrite endpoint received the prior data but the process
received a Ctrl+C, kill signal. However, this will be very rare and
would have to be timed so fast and precisely.

Replaces PR open-telemetry/opentelemetry-collector#3017
Updates PR open-telemetry/opentelemetry-collector#3597
Fixes open-telemetry#4751
Fixes open-telemetry/wg-prometheus#9
    @odeke-em
    odeke-em committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    8b5d368 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. fix go.mod 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    b113a59 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL

Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    209c650 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    800f9cd View commit details
    Browse the repository at this point in the history

  2. exporter/prw: WALConfig should be exported to allow programmatic mani… 

    …pulation

Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    06a1c48 View commit details
    Browse the repository at this point in the history

  3. Add CHANGELOG entry 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    875897b View commit details
    Browse the repository at this point in the history

  4. fix lint error 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    d76771b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL

Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    c055725 View commit details
    Browse the repository at this point in the history

  6. mod tidy 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    31a0941 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    2b11f30 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    702584a View commit details
    Browse the repository at this point in the history

  2. tidy up WAL logic and comments 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    26d9b75 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into exporter-prometheusremotewrite-hookup-WAL

    Alex Boten authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    6b043de View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    0044c37 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'a9/exporter-prometheusremotewrite-hooku… 

    …p-WAL' into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    22b3f60 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Merge branch 'main' into exporter-prometheusremotewrite-hookup-WAL

    @jpkrohling
    jpkrohling authored Jan 28, 2022
    Configuration menu
    Copy the full SHA
    a7853ed View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    a687a57 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL

Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    6a749e5 View commit details
    Browse the repository at this point in the history

  3. Handle error from closing WAL 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    4a2dc2f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Ensure WAL processor keeps running after error 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    9bbef4f View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    c1f39ee View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2022

  1. prwe/WAL: refactor WAL run loop 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    65dfa99 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'a9/exporter-prometheusremotewrite-hooku… 

    …p-WAL' into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    5f4188d View commit details
    Browse the repository at this point in the history

  3. make gotidy 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    20b7e57 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    d5d26f5 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'a9/exporter-prometheusremotewrite-hooku… 

    …p-WAL' into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    8a2ca9b View commit details
    Browse the repository at this point in the history

  6. lint 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    2913547 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    a9d50b9 View commit details
    Browse the repository at this point in the history

  2. fix data races 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    be040f0 View commit details
    Browse the repository at this point in the history

  3. Ensure locking around entire WAL persistence routine 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    5d611fd View commit details
    Browse the repository at this point in the history

  4. Address PR feedback 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    5a6d11c View commit details
    Browse the repository at this point in the history

  5. fix lint issues 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    2b3f568 View commit details
    Browse the repository at this point in the history

  6. update read index inside WAL reader routine 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    f861153 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    410f934 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. Update CHANGELOG.md

    @Aneurysm9
    Aneurysm9 authored Mar 3, 2022
    Configuration menu
    Copy the full SHA
    008f6ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    a90b53b View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib into exporter-prometheusremotewrite-hookup-WAL
    @Aneurysm9
    Aneurysm9 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    1839a2d View commit details
    Browse the repository at this point in the history

  2. Undo unrelated go.mod changes 

    Signed-off-by: Anthony J Mirabella <[email protected]>
    @Aneurysm9
    Aneurysm9 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    5ec4301 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into exporter-prometheusremotewrite-hookup-WAL

    @jpkrohling
    jpkrohling authored Mar 7, 2022
    Configuration menu
    Copy the full SHA
    2e123ab View commit details
    Browse the repository at this point in the history