-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/simpleprometheus] Add support for static labels #7908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Please add a note about this enhancement to CHANGELOG.md.
Pinging code owner @asuresh4
7f4e61e
to
705f799
Compare
Thanks! changelog is updated. |
17d9101
to
2007f67
Compare
Hi @asuresh4, any update? |
@codeboten he is no longer with the project :) |
Fair enough. I'll update the codeowners in a separate PR |
Removing @asuresh4 from code owners as per comment open-telemetry#7908 (comment)
@codeboten @bogdandrutu , is there any way we can move forward with this? @newly12 please rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I don't have a lot of familiarity with this receiver, the change looks fine.
* updating codeowners Removing @asuresh4 from code owners as per comment #7908 (comment) * Update CODEOWNERS Co-authored-by: Bogdan Drutu <[email protected]>
Part of open-telemetry#7895 Signed-off-by: Alex Boten <[email protected]>
Description:
Add support for static labels in simpleprometheusreceiver
Link to tracking Issue:
Testing:
1 test has been updated to include static label
Documentation: