Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/simpleprometheus] Add support for static labels #7908

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

newly12
Copy link
Contributor

@newly12 newly12 commented Feb 14, 2022

Description:

Add support for static labels in simpleprometheusreceiver

Link to tracking Issue:

Testing:
1 test has been updated to include static label

Documentation:

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please add a note about this enhancement to CHANGELOG.md.

Pinging code owner @asuresh4

@newly12
Copy link
Contributor Author

newly12 commented Feb 16, 2022

Thanks! changelog is updated.

@newly12
Copy link
Contributor Author

newly12 commented Feb 22, 2022

Hi @asuresh4, any update?

@bogdandrutu
Copy link
Member

@codeboten he is no longer with the project :)

@codeboten
Copy link
Contributor

@codeboten he is no longer with the project :)

Fair enough. I'll update the codeowners in a separate PR

codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Mar 2, 2022
Removing @asuresh4 from code owners as per comment open-telemetry#7908 (comment)
@codeboten codeboten mentioned this pull request Mar 2, 2022
@vjsamuel
Copy link

vjsamuel commented Mar 3, 2022

@codeboten @bogdandrutu , is there any way we can move forward with this? @newly12 please rebase.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't have a lot of familiarity with this receiver, the change looks fine.

@codeboten codeboten merged commit 255f3a3 into open-telemetry:main Mar 4, 2022
@newly12 newly12 deleted the simple_prom_labels branch March 5, 2022 02:05
codeboten pushed a commit that referenced this pull request Mar 18, 2022
* updating codeowners

Removing @asuresh4 from code owners as per comment #7908 (comment)

* Update CODEOWNERS

Co-authored-by: Bogdan Drutu <[email protected]>
ZahidMirza95 pushed a commit to ZahidMirza95/opentelemetry-collector-contrib that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants