[processor/attributesprocessor] Add metric support #8111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
reviewed
Feb 24, 2022
dmitryax
reviewed
Feb 25, 2022
pmm-sumo
reviewed
Feb 25, 2022
This change adds metric support to the attributes processor. Metric data point attributes can now be modified in all of the same ways as spans and logs. This change also adds testing that is all passing.
crobert-1
force-pushed
the
metric_attribute_processor
branch
from
a7f5b89
to
cfb95a7
Compare
crobert-1
force-pushed
the
metric_attribute_processor
branch
4 times, most recently
from
c64a217
to
230455f
Compare
- Remove out-dated comments - Change all span/log/metric references to "input data" - Add comments about usage of attributes processor vs. metric transform processor.
crobert-1
force-pushed
the
metric_attribute_processor
branch
from
230455f
to
1460223
Compare
dmitryax
reviewed
Mar 5, 2022
- Add logging when skipping metrics - Add links to different processors
codeboten
reviewed
Mar 9, 2022
There was a problem hiding this comment.
@pmm-sumo @pmcollins @tigrannajaryan please take a look and approve if your comments have been addressed
tigrannajaryan
approved these changes
Mar 9, 2022
pmcollins
approved these changes
Mar 10, 2022
pmm-sumo
approved these changes
Mar 10, 2022
codeboten
approved these changes
Mar 10, 2022
This was referenced Mar 13, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds metric support to the attributes processor. Metric data point attributes can now be modified in all of the same ways as spans and logs.
Link to tracking Issue:
Testing:
Included unit tests, also did manual testing. Manual tests show that insert, delete and extract were all working as expected.
Documentation:
README was updated, as well as extra comments in shared attributes processor code.