[exporter/tanzuobservability]Instrumentation Library and Dropped Counts to Span Tags #8120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add following span-tags: otel.dropped_events_count otel.dropped_links_count otel.dropped_attributes_co otel.span.name otel.span.version
Add instrumentation Library and Dropped Counts to Span Tags.
keep94
suggested changes
Feb 25, 2022
Misc updates.
keep94
suggested changes
Feb 25, 2022
Misc updates.
keep94
approved these changes
Feb 25, 2022
|
Merged lastest changes from the |
codeboten
reviewed
Feb 28, 2022
Co-authored-by: Alex Boten <[email protected]>
|
@codeboten please review. |
|
@codeboten the unit test failure does not look like related to our changes. Failure: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/5470161638?check_suite_focus=true |
|
The tests are now passing. |
codeboten
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add following span-tags:
otel.dropped_events_count
otel.dropped_links_count
otel.dropped_attributes_co
otel.span.name
otel.span.version
Link to tracking Issue: N/A
Testing: Unit and manual testing
Documentation: N/A