[prometheusreceiver and prometheusremotewriteexporter] Update resource attributes used when translating to/from prometheus #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
prom_semantic_conv
branch
2 times, most recently
from
ac1a06f
to
bb88142
Compare
Aneurysm9
approved these changes
Mar 7, 2022
dashpole
force-pushed
the
prom_semantic_conv
branch
from
bb88142
to
f4621f7
Compare
codeboten
reviewed
Mar 8, 2022
dashpole
force-pushed
the
prom_semantic_conv
branch
2 times, most recently
from
242ad5b
to
4739572
Compare
dashpole
force-pushed
the
prom_semantic_conv
branch
from
4739572
to
d14c933
Compare
codeboten
approved these changes
Mar 11, 2022
jpkrohling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #8264.
Fixes #7081.
This PR updates the resource attributes used when translating to and from prometheus to match the prometheus conversion specification, which was updated in open-telemetry/opentelemetry-specification#2381 with these attributes.
Testing: Unit tests were updated. Prometheus compatibility tests still pass after this change.