Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update InfluxDB dependencies #8348

Merged
merged 2 commits into from
Mar 9, 2022
Merged

chore: update InfluxDB dependencies #8348

merged 2 commits into from
Mar 9, 2022

Conversation

jacobmarble
Copy link
Contributor

Description:
When converting from OTel to line protocol with either of the Prometheus-style schemata, we follow the OTel guidance for Prometheus. Specifically:

OpenTelemetry Sums follows this logic:
...
If the aggregation temporality is cumulative and the sum is non-monotonic, it MUST be converted to a Prometheus Gauge.

Link to tracking Issue:

#8341
influxdata/influxdb-observability#50
influxdata/influxdb-observability#51

Testing:
Tests added to dependencies (see PR 51 above) and no change to otelcontribcol in this PR.

Documentation:
None needed. This is a bug fix.

@jacobmarble jacobmarble requested review from a team and mx-psi March 8, 2022 23:22
@pmm-sumo
Copy link
Contributor

pmm-sumo commented Mar 8, 2022

Seems that linter and unittest failed:

go: downloading github.com/influxdata/influxdb-observability/influx2otel v0.2.14
go: updates to go.mod needed; to update it:
	go mod tidy

Also, changelog entry is missing

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 9, 2022
@codeboten
Copy link
Contributor

Also, changelog entry is missing

This change is probably ok without changelog. I've added the label to it

@codeboten
Copy link
Contributor

This change is probably ok without changelog. I've added the label to it

This is just based on the title of the PR. According to the description this is also a bugfix... If it's the latter, please add a changelog, if the former, please update the description :)

@jacobmarble
Copy link
Contributor Author

jacobmarble commented Mar 9, 2022

please add a changelog

Done.

Seems that linter and unittest failed

I found make gotidy and make golint. Let's see if this helps.

@jpkrohling jpkrohling merged commit 488e701 into open-telemetry:main Mar 9, 2022
@jacobmarble jacobmarble deleted the influxdb-update-deps branch March 9, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants