[prometheusremotewriteexporter] Drop prometheus exemplar labels when the max length is exceeded #8379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
max_examplar_size
branch
2 times, most recently
from
69afeb2
to
bf1d1a7
Compare
mx-psi
reviewed
Mar 10, 2022
Aneurysm9
reviewed
Mar 10, 2022
dashpole
force-pushed
the
max_examplar_size
branch
from
bf1d1a7
to
7ecf70e
Compare
Aneurysm9
approved these changes
Mar 10, 2022
dashpole
force-pushed
the
max_examplar_size
branch
from
7ecf70e
to
7d54b2f
Compare
mx-psi
approved these changes
Mar 14, 2022
pmm-sumo
approved these changes
Mar 14, 2022
mx-psi
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #8352. This follows the OTLP -> Prometheus specification for handling exemplar labels.
Testing:
Added a unit test