Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Remove GetHostTags method #9423

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 25, 2022

Description:

Remove deprecated GetHostTags method. This is a breaking change, but does not affect end-users since it is a Go API only change.

This change is split off from #9249, since we have decided to do all end-user breaking changes in a single future release.

Link to tracking Issue: #8373

@mx-psi mx-psi marked this pull request as ready for review April 25, 2022 11:49
@mx-psi mx-psi requested review from a team and dmitryax April 25, 2022 11:49
CHANGELOG.md Outdated Show resolved Hide resolved
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Apr 26, 2022
@jpkrohling jpkrohling merged commit 2b3ccee into open-telemetry:main Apr 26, 2022
@mx-psi mx-psi deleted the mx-psi/remove-get-host-tags-fun branch April 26, 2022 14:13
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
* [exporter/datadog] Remove `GetHostTags` method

* Add PR number in CHANGELOG

* Apply suggestions from code review

Co-authored-by: Kylian Serrania <[email protected]>

Co-authored-by: Kylian Serrania <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants