Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report fatal error if err is server closed #9559

Merged
merged 2 commits into from
May 3, 2022

Conversation

bogdandrutu
Copy link
Member

Because we use the cmux, closing the listener causes the cmux to close which will cause the grpc/http servers to also close with a cmux.ErrServerClosed error.

Fixes open-telemetry/opentelemetry-collector#5261

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and dmitryax April 27, 2022 17:52
@bogdandrutu bogdandrutu force-pushed the occloseerr branch 2 times, most recently from 3f511bb to 0b7e8c7 Compare April 27, 2022 18:29
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Because we use the cmux, closing the listener causes the cmux to close which will cause the grpc/http servers to also close with a `cmux.ErrServerClosed` error.

Signed-off-by: Bogdan Drutu <[email protected]>
@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label May 3, 2022
@codeboten codeboten merged commit aaae303 into open-telemetry:main May 3, 2022
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
Because we use the cmux, closing the listener causes the cmux to close which will cause the grpc/http servers to also close with a `cmux.ErrServerClosed` error.

Signed-off-by: Bogdan Drutu <[email protected]>

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opencensus receiver throws error on close
5 participants