[exporter/datadog] Fix host alias field in metadata payload & fix GCP host alias. #9748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
May 5, 2022
Comment on lines
46
to
49
| // Add host id as a host alias to preserve backwards compatibility | ||
| // The Datadog Agent does not do this | ||
| hostInfo.HostAliases = append(hostInfo.HostAliases, hostID.StringVal()) | ||
| if cloudAccount, ok := attrs.Get(conventions.AttributeCloudAccountID); ok { | ||
| alias := fmt.Sprintf("%s.%s", hostID.StringVal(), cloudAccount.StringVal()) | ||
| hostInfo.HostAliases = append(hostInfo.HostAliases, alias) | ||
| } |
There was a problem hiding this comment.
Note for future git history spelunkers: this is not a breaking change since we were not sending host aliases at all to the backend.
|
🤔 Could you do an empty commit? Github Actions is not running for some reason on your last commit (or alternatively, fix the conflict with the changelog) |
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
approved these changes
May 24, 2022
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
… host alias. (open-telemetry#9748) * [exporter/datadog] Fix host_alias json field * Update GCP host alias computation * Add release note * Fix tests * Fix GCP host alias resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes the metadata payload field name used to send host aliases to the Datadog backend (the correct field is
host_aliases, nothost-aliases, see this datadog-agent code for comparison).Also fixes the GCP host alias resolution to match what is done in the datadog-agent. Since we weren't sending this host alias correctly at all before, we consider this not to be a breaking change.
Link to tracking Issue: #9122
Testing: Amended the unit test for the GCP host alias. Manually checked that host aliases are now properly seen in the Datadog backend when the
Meta.HostAliasesfield is not empty.Documentation: n/a