-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GoReleaser: publish Homebrew formula to a Tap on each new release #460
base: main
Are you sure you want to change the base?
Conversation
hey @edigaryev, thanks for creating this PR and bumping the discussion around the collector in homebrew.
With what is called bottles in the homebrew ecosystem this is not the case anymore, those are binary packages, and "Bottles for homebrew/core formulae are created by Brew Test Bot when a pull request is submitted. If the formula builds successfully on each supported platform and a maintainer approves the change, Brew Test Bot updates its bottle do block and uploads each bottle to GitHub Packages." (see https://docs.brew.sh/Bottles#creation)
As I have outlined in my comment my personal preference would be a formulae on homebrew/core, because of discoverability and user expectations, but it's up to the collector maintainers to decide what they think is easier to maintain. As a final note, I also like to re-iterate on the following:
The initial provider of that formulae (@flier), who initially pushed cc @open-telemetry/cpp-approvers please correct me if I am wrong about this package not coming from any member of your SIG? |
@svrnm thanks for the input! I've just realized that this project produces the binaries with I went ahead and submitted a PR with a Homebrew formula (inspired by yours one) upstream: Homebrew/homebrew-core#160730, so closing this one. |
Re-opening because it's not possible to upstream the OpenTelemetry Collector into the Homebrew Core, see open-telemetry/opentelemetry-collector#7891 (comment) |
Please help resolve conflicts? |
Done in b4cfdb9 👌 |
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Please see the CI |
Moved the "brews:"-related GoReleaser configuration generation to the Golang codebase in 3b48905. |
Should the k8s distro have a formula? |
Note that going down the road of having our own tap requires a dedicated repository:
|
It seems to be Linux-only (which makes sense):
|
Currently installing OpenTelemetry Collector on macOS is pretty painful compared to Grafana Agent, see open-telemetry/opentelemetry-collector#7891.
However, publishing a formula to a Homebrew/homebrew-core can be intimidating both for the maintainers and consumers:
A simpler, self-managed and readily available alternative is a Homebrew Tap.
Since OpenTelemetry already uses GoReleaser, and GoReleaser has a Homebrew Taps module, publishing a Tap becomes a no-brainer (see PR diff for a minimally working implementation).
Installing from a Tap is as simple as:
Requires open-telemetry/homebrew-tap repository to be created and accessible via
GITHUB_TOKEN
.Cc: @svrnm, @jpeach