change goreleaser for builder to use GITHUB_TOKEN #707
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
approved these changes
Oct 23, 2024
mx-psi
approved these changes
Oct 23, 2024
codeboten
approved these changes
Oct 23, 2024
songy23
approved these changes
Oct 23, 2024
|
Thanks @jackgopack4! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release was failing as GH_PAT is not a valid secret in open-telemetry/opentelemetry-collector-releases
This is a fix to unblock release of
ocbfor versions 0.112.0 and beyond.Please see the sample releases in my fork:
https://github.com/jackgopack4/opentelemetry-collector-releases/actions/runs/11483616588/job/31959465698
https://github.com/jackgopack4/opentelemetry-collector-releases/releases/tag/cmd/builder/v0.112.0
https://github.com/jackgopack4/opentelemetry-collector-releases/pkgs/container/opentelemetry-collector-releases%2Fopentelemetry-collector-builder
https://hub.docker.com/layers/johnpeterson785/opentelemetry-collector-builder/0.112.0/images/sha256-6a85c23fe59f516a23ff5627cff1ee3328167f1e3846fa9cd00760af0bdff568?context=explore
We should also consider removing reference to
GH_PATin other workflow files but this is not necessary to unblock v0.112.0 release