Skip to content

Commit

Permalink
try aliasing the struct names instead
Browse files Browse the repository at this point in the history
  • Loading branch information
atoulme committed Jan 25, 2024
1 parent bd6482b commit 4116477
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions exporter/exporterhelper/queue_sender.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ var (

// QueueSettings defines configuration for queueing batches before sending to the consumerSender.
// Deprecated: [v0.94.0] Use QueueConfig instead
type QueueSettings struct {
QueueConfig `mapstructure:",squash"`
}
type QueueSettings QueueConfig

// QueueConfig defines configuration for queueing batches before sending to the consumerSender.
type QueueConfig struct {
Expand All @@ -50,7 +48,12 @@ type QueueConfig struct {
// Deprecated: [v0.94.0] Use NewDefaultQueueConfig instead
func NewDefaultQueueSettings() QueueSettings {
return QueueSettings{
NewDefaultQueueConfig(),
Enabled: true,
NumConsumers: 10,
// By default, batches are 8192 spans, for a total of up to 8 million spans in the queue
// This can be estimated at 1-4 GB worth of maximum memory usage
// This default is probably still too high, and may be adjusted further down in a future release
QueueSize: defaultQueueSize,
}
}

Expand Down

0 comments on commit 4116477

Please sign in to comment.