fix: interalize none and empty

open-telemetry · Jan 13, 2022 · bea771c · bea771c
1 parent 396f418
commit bea771c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/config/configcompression/compressionType.go b/config/configcompression/compressionType.go
@@ -24,12 +24,12 @@ const (
 	Deflate CompressionType = "deflate"
 	Snappy  CompressionType = "snappy"
 	Zstd    CompressionType = "zstd"
-	None    CompressionType = "none"
-	Empty   CompressionType = ""
+	none    CompressionType = "none"
+	empty   CompressionType = ""
 )
 
 func IsCompressed(compressionType CompressionType) bool {
-	return compressionType != Empty && compressionType != None
+	return compressionType != empty && compressionType != none
 }
 
 func (ct *CompressionType) UnmarshalText(in []byte) error {
@@ -39,8 +39,8 @@ func (ct *CompressionType) UnmarshalText(in []byte) error {
 		Deflate,
 		Snappy,
 		Zstd,
-		None,
-		Empty:
+		none,
+		empty:
 		*ct = typ
 		return nil
 	default:

diff --git a/config/configcompression/compressionType_test.go b/config/configcompression/compressionType_test.go
@@ -70,7 +70,7 @@ func TestUnmarshalText(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			temp := None
+			temp := none
 			err := temp.UnmarshalText(tt.compressionName)
 			if tt.shouldError {
 				assert.Error(t, err)