Skip to content

Commit

Permalink
[componentstatus] Remove deprecated functions (#11363)
Browse files Browse the repository at this point in the history
#### Description
Removes deprecated functions

#### Link to tracking issue
Related to
#9429
  • Loading branch information
TylerHelmuth authored Oct 4, 2024
1 parent 6a8c88d commit c5d9bbe
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 23 deletions.
25 changes: 25 additions & 0 deletions .chloggen/componentstatus-remove-deprecated-funcs.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: componentstatus

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove deprecated `NewInstanceIDWithPipelineIDs`, `AllPipelineIDsWithPipelineIDs`, and `WithPipelineIDs`. Use `NewInstanceID`, `AllPipelineIDs` and `WithPipelines` instead.

# One or more tracking issues or pull requests related to the change
issues: [11363]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
23 changes: 0 additions & 23 deletions component/componentstatus/instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@ func NewInstanceID(componentID component.ID, kind component.Kind, pipelineIDs ..
return instanceID
}

// NewInstanceIDWithPipelineIDs returns an InstanceID that uniquely identifies a component.
//
// Deprecated: [v0.111.0] Use NewInstanceIDWithPipelineID instead
func NewInstanceIDWithPipelineIDs(componentID component.ID, kind component.Kind, pipelineIDs ...pipeline.ID) *InstanceID {
return NewInstanceID(componentID, kind, pipelineIDs...)
}

// ComponentID returns the ComponentID associated with this instance.
func (id *InstanceID) ComponentID() component.ID {
return id.componentID
Expand Down Expand Up @@ -74,14 +67,6 @@ func (id *InstanceID) AllPipelineIDs(f func(pipeline.ID) bool) {
}
}

// AllPipelineIDsWithPipelineIDs calls f for each pipeline this instance is associated with. If
// f returns false it will stop iteration.
//
// Deprecated: [v0.111.0] Use AllPipelineIDs instead.
func (id *InstanceID) AllPipelineIDsWithPipelineIDs(f func(pipeline.ID) bool) {
id.AllPipelineIDs(f)
}

// WithPipelines returns a new InstanceID updated to include the given
// pipelineIDs.
func (id *InstanceID) WithPipelines(pipelineIDs ...pipeline.ID) *InstanceID {
Expand All @@ -94,14 +79,6 @@ func (id *InstanceID) WithPipelines(pipelineIDs ...pipeline.ID) *InstanceID {
return instanceID
}

// WithPipelineIDs returns a new InstanceID updated to include the given
// pipelineIDs.
//
// Deprecated: [v0.111.0] Use WithPipelines instead
func (id *InstanceID) WithPipelineIDs(pipelineIDs ...pipeline.ID) *InstanceID {
return id.WithPipelines(pipelineIDs...)
}

func (id *InstanceID) addPipelines(pipelineIDs []pipeline.ID) {
delim := string(pipelineDelim)
strIDs := strings.Split(id.pipelineIDs, delim)
Expand Down

0 comments on commit c5d9bbe

Please sign in to comment.