Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate URIs on http and https providers #10468

Closed
mx-psi opened this issue Jun 26, 2024 · 0 comments · Fixed by #10721
Closed

Validate URIs on http and https providers #10468

mx-psi opened this issue Jun 26, 2024 · 0 comments · Fixed by #10721
Labels
area:confmap enhancement New feature or request

Comments

@mx-psi
Copy link
Member

mx-psi commented Jun 26, 2024

The http and https providers don't do any validation of their URIs. This means it's hard for us to explore using alternative syntax for parameters as discussed on #10121. We should check whether net/http supports IDNAs and if so use https://pkg.go.dev/golang.org/x/net/idna for validation.

I argue this should be allowed after 1.0 since the URIs were invalid before and the behavior was unspecified for them.

@mx-psi mx-psi added enhancement New feature or request area:confmap labels Jun 26, 2024
mx-psi added a commit that referenced this issue Jul 25, 2024
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
<!-- Issue number if applicable -->

Validate URLs before fetching. 

#### Link to tracking issue
Fixes #10468, Relates to #10121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:confmap enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant