Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configgrpc needs to be refactored in accordance to the change in confighttp #4623

Closed
hyunuk opened this issue Jan 3, 2022 · 0 comments
Closed

configgrpc needs to be refactored in accordance to the change in confighttp #4623

hyunuk opened this issue Jan 3, 2022 · 0 comments
Assignees
@hyunuk
Labels
area:internal enhancement New feature or request

Comments

@hyunuk
Copy link
Contributor

hyunuk commented Jan 3, 2022

Is your feature request related to a problem? Please describe.

#4441 (comment)

It can be shareable. I removed usages of these values in confighttp and made connection to middleware.CompressionType.
To connect these values with configgrpc, I discussed with @Aneurysm9 and since the changes in confighttp are quite a lot, he will create an issue about refactoring configgrpc after this PR is being merged.

Since the PR for confighttp introduced CompressionType that can be shareable with grpc, configgrpc part needs to be refactored.

Describe the solution you'd like
use middleware.CompressionType instead of it's own constants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyunuk hyunuk

Labels
area:internal enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @hyunuk