Support Snappy and Zstd for confighttp.go #4441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 16, 2021 16:49
…ression from otlp
…nto http_encoding
Codecov Report
@@ Coverage Diff @@
## main #4441 +/- ##
=======================================
Coverage 90.52% 90.53%
=======================================
Files 180 180
Lines 10474 10503 +29
=======================================
+ Hits 9482 9509 +27
- Misses 776 777 +1
- Partials 216 217 +1
Continue to review full report at Codecov.
|
|
@open-telemetry/collector-approvers please review. |
jpkrohling
reviewed
Nov 23, 2021
added 2 commits
November 23, 2021 12:44
codeboten
reviewed
Nov 23, 2021
Aneurysm9
reviewed
Nov 24, 2021
jpkrohling
reviewed
Nov 24, 2021
There was a problem hiding this comment.
This is looking great. I think @Aneurysm9's questions are the last remaining points.
added 2 commits
November 25, 2021 14:13
jpkrohling
reviewed
Nov 26, 2021
jpkrohling
reviewed
Nov 30, 2021
added 2 commits
November 30, 2021 15:16
Aneurysm9
approved these changes
Dec 2, 2021
Aneurysm9
added
the
ready-to-merge
codeboten
approved these changes
Dec 2, 2021
…nto http_encoding
bogdandrutu
reviewed
Dec 2, 2021
bogdandrutu
reviewed
Dec 3, 2021
added 2 commits
December 5, 2021 11:31
6 tasks
added 2 commits
December 7, 2021 12:14
bogdandrutu
requested changes
Dec 8, 2021
added 3 commits
December 9, 2021 10:14
bogdandrutu
approved these changes
Dec 10, 2021
This was referenced Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR provides snappy and zstd as additional compression methods for
confighttp, which are the same libraries asconfiggrpcuses.The
compressionfield inexporter/otlphttpexporter/config.gohas been removed and integrated intoconfighttp.HTTPClientSettings.Link to tracking Issue:
#2766