Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pdata] Consider renaming AttributeValue to AnyValue #4818

Closed
dmitryax opened this issue Feb 8, 2022 · 1 comment
Closed

[pdata] Consider renaming AttributeValue to AnyValue #4818

dmitryax opened this issue Feb 8, 2022 · 1 comment
Assignees
@dmitryax
Milestone
go.opentelemetry....

Comments

@dmitryax
Copy link
Member

dmitryax commented Feb 8, 2022

pdata.AttributeValue is a wrapper over opentelemetry.proto.common.v1.AnyValue type. It's not exclusively used with pdata.AttributeMap, pdata.LogRecord.Body also uses it, proto. So it's a bit confusing why Log record body has a value of AttributeValue type.

The proposal is to rename AttributeValue type to AnyValue which matches the proto field type.
@Aneurysm9 Aneurysm9 mentioned this issue Feb 8, 2022
Closed
@dmitryax dmitryax changed the title Consider renaming pdata.AttributeValue to pdata.AnyValue [pdata] Consider renaming AttributeValue to AnyValue Feb 8, 2022
This was referenced Mar 10, 2022
Merged
Closed
@bogdandrutu
Copy link
Member

This is done correct? Feel free to reopen if that is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitryax dmitryax

Labels
None yet
Projects
None yet
Milestone
go.opentelemetry.io/collector/pdata 1.0
Development

No branches or pull requests
2 participants
@bogdandrutu @dmitryax