Rename pdata.AttributeValue to pdata.Value #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
pdata-any-value
branch
from
d961f59
to
167d450
Compare
Codecov Report
@@ Coverage Diff @@
## main #4978 +/- ##
==========================================
+ Coverage 90.92% 90.96% +0.03%
==========================================
Files 183 183
Lines 10692 10692
==========================================
+ Hits 9722 9726 +4
+ Misses 752 749 -3
+ Partials 218 217 -1
Continue to review full report at Codecov.
|
codeboten
reviewed
Mar 11, 2022
dmitryax
force-pushed
the
pdata-any-value
branch
from
167d450
to
bdf80fc
Compare
|
@codeboten thanks for the review. I addressed all your comments |
dmitryax
force-pushed
the
pdata-any-value
branch
2 times, most recently
from
555da20
to
11dc60a
Compare
codeboten
approved these changes
Mar 11, 2022
bogdandrutu
reviewed
Mar 13, 2022
dmitryax
force-pushed
the
pdata-any-value
branch
4 times, most recently
from
ff2e1e5
to
081b8b9
Compare
|
I realized that this PR solves only part of the problem. Removed Will keep this PR in draft until we have an agreement on the path forward. |
dmitryax
force-pushed
the
pdata-any-value
branch
from
081b8b9
to
cdfb20c
Compare
dmitryax
changed the title
|
The PR is updated to use |
bogdandrutu
reviewed
Mar 15, 2022
dmitryax
force-pushed
the
pdata-any-value
branch
3 times, most recently
from
bc6dee5
to
06b6862
Compare
`pdata.AttributeValue` is a wrapper over `opentelemetry.proto.common.v1.AnyValue` type. It's not exclusively used with Attributes field, `pdata.LogRecord.Body` also uses it which makes the name misleading. This change renames all API related to `pdata.AttributeValue` to `pdata.Value` keeping the old API as deprecated
dmitryax
force-pushed
the
pdata-any-value
branch
from
06b6862
to
5e0526f
Compare
bogdandrutu
approved these changes
Mar 16, 2022
codeboten
approved these changes
Mar 16, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
`pdata.AttributeValue` is a wrapper over `opentelemetry.proto.common.v1.AnyValue` type. It's not exclusively used with Attributes field, `pdata.LogRecord.Body` also uses it which makes the name misleading. This change renames all API related to `pdata.AttributeValue` to `pdata.Value` keeping the old API as deprecated Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pdata.AttributeValueis a wrapper overopentelemetry.proto.common.v1.AnyValuetype. It's not exclusively used with Attributes field,pdata.LogRecord.Bodyalso uses it which makes the name misleading. This change renames all API related topdata.AttributeValuetopdata.Valuekeeping the old API as deprecated.Updates: #4818
UPD: The PR is updated to use
Valuenaming instead ofAnyValueas suggested by @bogdandrutu in #4988 (comment)