Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update telemetry code to support more than a single prometheus instance #7533

Closed
Tracked by #7532
codeboten opened this issue Apr 12, 2023 · 0 comments · Fixed by #7534
Closed
Tracked by #7532

Update telemetry code to support more than a single prometheus instance #7533

codeboten opened this issue Apr 12, 2023 · 0 comments · Fixed by #7534
Assignees
@codeboten

Comments

@codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten mentioned this issue Apr 12, 2023
Open
5 tasks
@codeboten codeboten self-assigned this Apr 12, 2023
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Apr 12, 2023
move prometheus init code
9de985e 
This is moving the code to initialize the prometheus endpoint into a separate func. This will allow us to run it multiple times if a user configures multiple prometheus endpoints via telemetry configuration. This will also allow us to move that code inside a switch to only enable it if users configure prometheus export.

Fixes open-telemetry#7533

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this issue Apr 12, 2023
Merged
codeboten pushed a commit that referenced this issue Apr 14, 2023
move prometheus init code (#7534)
cc471de 
This is moving the code to initialize the prometheus endpoint into a separate func. This will allow us to run it multiple times if a user configures multiple prometheus endpoints via telemetry configuration. This will also allow us to move that code inside a switch to only enable it if users configure prometheus export.

Fixes #7533

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move prometheus init code codeboten/opentelemetry-collector
1 participant
@codeboten