Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update make gensemconv to work with semantic-conventions repository #8686

Closed
mx-psi opened this issue Oct 16, 2023 · 0 comments · Fixed by #9063
Closed

Update make gensemconv to work with semantic-conventions repository #8686

mx-psi opened this issue Oct 16, 2023 · 0 comments · Fixed by #9063
Labels
area:semconv enhancement New feature or request

Comments

@mx-psi
Copy link
Member

mx-psi commented Oct 16, 2023

Since v1.21.0 semantic conventions have been published in the semantic-conventions repository. Our current gensemconv target does not work with this so we should update it and generate v1.21.0 and v1.22.0 conventions.
@mx-psi mx-psi added area:semconv enhancement New feature or request labels Oct 16, 2023
@mx-psi mx-psi mentioned this issue Dec 11, 2023
Merged
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Dec 11, 2023
[semconv] add 1.22.0 semantic conventions
f2e4925 
Fixes open-telemetry#8686

Signed-off-by: Alex Boten <[email protected]>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Dec 11, 2023
[semconv] add 1.22.0 semantic conventions
a334e3a 
Fixes open-telemetry#8686

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this issue Dec 11, 2023
Merged
codeboten pushed a commit that referenced this issue Dec 12, 2023
[semconv] add 1.22.0 semantic conventions (#9063)
2d49f09 
Generated with the following:

```
make gensemconv SPECPATH=/tmp/semantic-conventions SPECTAG=v1.22.0
```

Fixes
#8686

Signed-off-by: Alex Boten <[email protected]>
sokoide pushed a commit to sokoide/opentelemetry-collector that referenced this issue Dec 18, 2023
@sokoide
[semconv] add 1.22.0 semantic conventions (open-telemetry#9063)
d7071f0 
Generated with the following:

```
make gensemconv SPECPATH=/tmp/semantic-conventions SPECTAG=v1.22.0
```

Fixes
open-telemetry#8686

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:semconv enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[semconv] add 1.22.0 semantic conventions codeboten/opentelemetry-collector
1 participant
@mx-psi