Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config/confighttp] Resolve the TODO on confighttp.go related to prefixing operations with component id. #9382

Open
atoulme opened this issue Jan 24, 2024 · 3 comments · May be fixed by #11230
Assignees

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 24, 2024

From confighttp.go:

	// Enable OpenTelemetry observability plugin.
	// TODO: Consider to use component ID string as prefix for all the operations.
	handler = otelhttp.NewHandler(
		handler,
		"",
		otelhttp.WithTracerProvider(settings.TracerProvider),
		otelhttp.WithMeterProvider(settings.MeterProvider),
		otelhttp.WithPropagators(otel.GetTextMapPropagator()),
		otelhttp.WithSpanNameFormatter(func(operation string, r *http.Request) string {
			return r.URL.Path
		}),
	)

I have tried to resolve this TODO once before with #9123

@enesonus
Copy link

enesonus commented Jan 30, 2024

Hi @atoulme I would like to work on this issue. Is there any recommended readings or some files to look at? From what I understand, the span name formatter function can be used as a tool to set the prefix but I couldn't really understand how to get the component ID.

@atoulme
Copy link
Contributor Author

atoulme commented May 31, 2024

@enesonus go for it, not sure how to do it

@VihasMakwana
Copy link
Contributor

@atoulme can you assign this to me, I'll take it up.

@VihasMakwana VihasMakwana moved this from Todo to In Progress in Collector: v1 Sep 17, 2024
@VihasMakwana VihasMakwana moved this from In Progress to Waiting for reviews in Collector: v1 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for reviews
Development

Successfully merging a pull request may close this issue.

4 participants