-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confighttp]: add an option to add span prefix #11230
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11230 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 423 423
Lines 20233 20238 +5
=======================================
+ Hits 18510 18515 +5
Misses 1341 1341
Partials 382 382 ☔ View full report in Codecov by Sentry. |
@bogdandrutu @open-telemetry/collector-approvers I'd appreciate your review on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one nit, this looks sensible to me. Still definitely needs a look from @codeboten or @bogdandrutu who have more insight into this functionality.
Co-authored-by: Andrzej Stencel <[email protected]>
5e2319c
to
805a7b5
Compare
805a7b5
to
dffbad7
Compare
@bogdandrutu @codeboten The CI looks good now. PTAL! |
Description
This PR adds a new server option to modify span prefix.
it also updates
otlpreceiver
to use the option.Link to tracking issue
Fixes #9382
Testing
Added.
component.ID
is not available in this section of code. SinceToServer
is intended to be general and can be used byextensions
,receivers
, andexporters
, modifying it to acceptinternal.Settings
would introduce a breaking change, which I'm not comfortable with. Therefore, I believe it would be better to provide an option to change the prefix instead.