Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configcompression] Use if instead of switch on UnmarshalText #9458

Open
mx-psi opened this issue Feb 5, 2024 · 4 comments
Open

[configcompression] Use if instead of switch on UnmarshalText #9458

mx-psi opened this issue Feb 5, 2024 · 4 comments
Assignees
@AkhigbeEromo
Labels
area:config enhancement New feature or request

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 5, 2024 

          nit: Sorry, but my mind goes crazy when I see a switch used like an if :)) Can we fix this probably in a separate PR :)

Originally posted by @bogdandrutu in #9416 (comment)
@mx-psi
Copy link
Member Author

mx-psi commented Feb 5, 2024

I guess ideally we would have a linter for this

@mx-psi mx-psi added enhancement New feature or request area:config labels Feb 5, 2024
@mx-psi mx-psi mentioned this issue Feb 5, 2024
Merged
@mx-psi
Copy link
Member Author

mx-psi commented Feb 12, 2024

I don't think this is needed for 1.0 since it is an internal implementation detail, I am removing from the milestone

@mx-psi mx-psi mentioned this issue Feb 12, 2024
Open
@TylerHelmuth
Copy link
Member

I agree that this is not required for a 1.0 release.

@AkhigbeEromo
Copy link
Contributor

Hello @TylerHelmuth @mx-psi , i would like to work on this issue

@AkhigbeEromo AkhigbeEromo mentioned this issue Mar 23, 2024
Closed
@AkhigbeEromo AkhigbeEromo mentioned this issue Mar 25, 2024
Merged
codeboten added a commit that referenced this issue Apr 2, 2024
@AkhigbeEromo @TylerHelmuth @codeboten
[chore] Updated unmarshalText func (#9838)
b8e4fa7 
Changed the switch statement in` UnmarshalText` function to an if
statement {configcompression}
Link to the issue:
#9458

---------

Co-authored-by: Tyler Helmuth <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AkhigbeEromo AkhigbeEromo

Labels
area:config enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@atoulme @codeboten @mx-psi @TylerHelmuth @AkhigbeEromo