Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confignet] Should we change the name of NetAddr and NetTCP to end in Config? #9509

Closed
mx-psi opened this issue Feb 7, 2024 · 3 comments · Fixed by #9614
Closed

[confignet] Should we change the name of NetAddr and NetTCP to end in Config? #9509

mx-psi opened this issue Feb 7, 2024 · 3 comments · Fixed by #9614
Labels
area:config release:required-for-ga Must be resolved before GA release
Milestone
go.opentelemetry....

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 7, 2024 

          Few others:
  • NetAddr -> AddrConfig?
  • NetTCP -> TCPConfig?

Originally posted by @bogdandrutu in #9474 (comment)
@mx-psi mx-psi added release:required-for-ga Must be resolved before GA release area:config labels Feb 7, 2024
@bogdandrutu
Copy link
Member

Also we duplicate the "net" prefix in config[net].[Net]Addr for example

@mx-psi mx-psi mentioned this issue Feb 8, 2024
Merged
@arjunmahishi
Copy link
Contributor

arjunmahishi commented Feb 10, 2024 •
edited
Loading

Taking this up.

NetTCP -> TCPConfig?

@bogdandrutu I am assuming, by this you mean TCPAddr ?

opentelemetry-collector/config/confignet/confignet.go

Lines 48 to 49 in de6287d

// TCPAddr represents a TCP endpoint address.
type TCPAddr struct {

EDIT: Nevermind. I missed the PR that already addresses this.

arjunmahishi added a commit to arjunmahishi/opentelemetry-collector that referenced this issue Feb 10, 2024
@arjunmahishi
[confignet] Rename Addr and TCP config structs
a49b105 
This commit renames the following structs:

* NetAddr to AddrConfig
* TCPAddr to TCPConfig

Fixes open-telemetry#9509
@arjunmahishi arjunmahishi mentioned this issue Feb 10, 2024
Closed
bogdandrutu pushed a commit that referenced this issue Feb 13, 2024
@mx-psi
[confignet] Rename NetAddr and TCPAddr to follow conventions (#9529)
5cfc68f 
**Description:** 

Rename types in `confignet` to adapt to conventions (avoid stuttering
and end in `Config`)

**Link to tracking Issue:** Updates #9509
@TylerHelmuth TylerHelmuth mentioned this issue Feb 20, 2024
Merged
@TylerHelmuth
Copy link
Member

Requires open-telemetry/opentelemetry-collector-contrib#31354

@braydonk braydonk mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config release:required-for-ga Must be resolved before GA release
Projects
Collector: v1
Archived in project
Milestone
go.opentelemetry.io/collector/config/...
4 participants
@bogdandrutu @mx-psi @arjunmahishi @TylerHelmuth