Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/rs/cors to v1.11.0 #10045

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 30, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/rs/cors v1.10.1 -> v1.11.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

rs/cors (github.com/rs/cors)

v1.11.0

Compare Source


Configuration

📅 Schedule: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 30, 2024
@renovate renovate bot requested a review from a team April 30, 2024 00:52
@renovate renovate bot added the renovatebot label Apr 30, 2024
@renovate renovate bot requested a review from mx-psi April 30, 2024 00:52
@mx-psi mx-psi closed this Apr 30, 2024
@mx-psi mx-psi reopened this Apr 30, 2024
@mx-psi
Copy link
Member

mx-psi commented Apr 30, 2024

The error on CI is possibly related to rs/cors/issues/176

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 15, 2024
@renovate renovate bot force-pushed the renovate/github.com-rs-cors-1.x branch from cf04bff to 4f05cd3 Compare May 15, 2024 13:35
@mx-psi mx-psi removed the Stale label May 15, 2024
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 1, 2024
@renovate renovate bot changed the title fix(deps): update module github.com/rs/cors to v1.11.0 Update module github.com/rs/cors to v1.11.0 Jun 3, 2024
@renovate renovate bot force-pushed the renovate/github.com-rs-cors-1.x branch from 9bbb91e to 0a6d39d Compare June 3, 2024 09:04
@github-actions github-actions bot removed the Stale label Jun 5, 2024
@renovate renovate bot force-pushed the renovate/github.com-rs-cors-1.x branch from cf864d8 to eb23353 Compare June 5, 2024 10:11
@mx-psi mx-psi closed this Jun 5, 2024
@mx-psi mx-psi reopened this Jun 5, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 22, 2024
@renovate renovate bot changed the title Update module github.com/rs/cors to v1.11.0 fix(deps): update module github.com/rs/cors to v1.11.0 Jul 2, 2024
@renovate renovate bot force-pushed the renovate/github.com-rs-cors-1.x branch from ac8a986 to ecb0de4 Compare July 2, 2024 20:26
@codeboten codeboten closed this Jul 2, 2024
@codeboten codeboten reopened this Jul 2, 2024
@codeboten codeboten removed the Stale label Jul 2, 2024
The test was broken by the change in the cors library
rs/cors#171

Signed-off-by: Alex Boten <[email protected]>
@codeboten
Copy link
Contributor

updated the test in #10519, @mx-psi PTAL

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.38%. Comparing base (6ad6b86) to head (52e75d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10045      +/-   ##
==========================================
- Coverage   92.39%   92.38%   -0.02%     
==========================================
  Files         393      393              
  Lines       18614    18614              
==========================================
- Hits        17199    17196       -3     
- Misses       1058     1060       +2     
- Partials      357      358       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but does this behavior change need a release note?

@codeboten
Copy link
Contributor

@mx-psi as it's a change in the underlying library, we don't usually document those

@codeboten codeboten merged commit 8d4b83b into main Jul 3, 2024
50 checks passed
@codeboten codeboten deleted the renovate/github.com-rs-cors-1.x branch July 3, 2024 18:17
@github-actions github-actions bot added this to the next release milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file renovatebot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants