-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] Add featuregate to use stable expansion rules #10391
[confmap] Add featuregate to use stable expansion rules #10391
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10391 +/- ##
=======================================
Coverage 92.39% 92.40%
=======================================
Files 387 387
Lines 18310 18323 +13
=======================================
+ Hits 16918 16931 +13
Misses 1046 1046
Partials 346 346 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change and it's good to go from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebasing
Description
This PR adds a feature gate that will handle transitioning users away from expandconverter, specifically expanding
$VAR
syntax.The wholistic strategy is:
confmap.unifyEnvVarExpansion
, that will be the single feature gate to manage unifying collector configuraiton resolution.$VAR
syntax.otelcol.NewCommand
to set aDefaultScheme="env"
when the feature gate is enabled and noDefaultScheme
is set, this handles${VAR}
syntax.expandconverter
.confmap.unifyEnvVarExpansion
feature gates andexpandconverter
at the same timeSupersedes #10259
Link to tracking issue
Related to #10161
Related to #8215
Related to #7111
Testing
Unit tests