[service] add internal factory method for meter provider #10415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used when moving the meter provider configuration to use the otel-go config package. Part of open-telemetry#10414 Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10415 +/- ##
==========================================
- Coverage 92.39% 92.35% -0.04%
==========================================
Files 393 393
Lines 18614 18622 +8
==========================================
Hits 17199 17199
- Misses 1058 1066 +8
Partials 357 357 ☔ View full report in Codecov by Sentry. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Ping @mx-psi for review |
mx-psi
reviewed
Jul 5, 2024
Co-authored-by: Pablo Baeyens <[email protected]>
mx-psi
approved these changes
Jul 5, 2024
codeboten
commented
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used when moving the meter provider configuration to use the otel-go config package.
Part of #10414
Skipping changelog as there's no usage of this method yet. It will be done in a separate PR