Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/debug] format metric data points as one-liners in normal verbosity #10462

Conversation

andrzej-stencel
Copy link
Member

Description

This pull request is part of #7806; it implements the change for metrics. The changes for logs and traces have been proposed in separate pull requests.

This change applies to the Debug exporter only. The behavior of the Logging exporter remains unchanged. To use this behavior, switch from the deprecated Logging exporter to Debug exporter.

Link to tracking issue

Testing

Added unit tests for the formatter.

Documentation

Described the formatting in the Debug exporter's README.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.49%. Comparing base (3364ba1) to head (66fae40).

Files Patch % Lines
exporter/debugexporter/internal/normal/metrics.go 97.70% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10462      +/-   ##
==========================================
+ Coverage   92.46%   92.49%   +0.02%     
==========================================
  Files         390      391       +1     
  Lines       18461    18551      +90     
==========================================
+ Hits        17070    17158      +88     
- Misses       1036     1038       +2     
  Partials      355      355              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 24, 2024
The span attributes were missing
@mx-psi mx-psi merged commit 1d1ff4a into open-telemetry:main Jun 24, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 24, 2024
@andrzej-stencel andrzej-stencel deleted the debug-exporter-normal-verbosity-metrics branch June 27, 2024 08:20
@andrzej-stencel andrzej-stencel added the exporter/debug Issues related to the Debug exporter label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/debug Issues related to the Debug exporter Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants