Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Improve docs for server-like receivers in kubernetes and docker #10562

Merged
merged 12 commits into from
Jul 22, 2024

Conversation

ankitpatel96
Copy link
Contributor

Improves the docs on how to setup networking in common environments now that the collector binds to localhost by default.

Link to tracking issue

Fixes #10548

Testing

Tested the Kubernetes setup on a cluster

@ankitpatel96 ankitpatel96 requested review from a team and bogdandrutu July 8, 2024 22:54
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (b127da0) to head (d569495).
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10562      +/-   ##
==========================================
+ Coverage   92.35%   92.39%   +0.03%     
==========================================
  Files         393      403      +10     
  Lines       18622    18744     +122     
==========================================
+ Hits        17199    17318     +119     
  Misses       1066     1066              
- Partials      357      360       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/security-best-practices.md Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
@ankitpatel96 ankitpatel96 changed the title Improve docs for server-like receivers in kubernetes and docker [chore] Improve docs for server-like receivers in kubernetes and docker Jul 9, 2024
@ankitpatel96 ankitpatel96 requested a review from mx-psi July 10, 2024 18:03
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 11, 2024
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Show resolved Hide resolved
docs/security-best-practices.md Outdated Show resolved Hide resolved
docs/security-best-practices.md Show resolved Hide resolved
@ankitpatel96 ankitpatel96 requested a review from mx-psi July 22, 2024 13:45
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me, looks good to me!

@mx-psi mx-psi merged commit f085ac4 into open-telemetry:main Jul 22, 2024
52 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Provide explicit guidance on how to configure server-like receivers in common environments
3 participants