-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance builder to capture go module for each component type #10599
Conversation
7108dec
to
e2e0d65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10599 +/- ##
==========================================
- Coverage 92.34% 92.27% -0.07%
==========================================
Files 395 397 +2
Lines 18669 18729 +60
==========================================
+ Hits 17240 17283 +43
- Misses 1069 1086 +17
Partials 360 360 ☔ View full report in Codecov by Sentry. |
9092fd5
to
9add3c0
Compare
Hmm, I thought I had tests passing. I'll move this back to draft status until I get CI resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
I think the current placement is good for use in the |
cbb3d56
to
9add3c0
Compare
9add3c0
to
1ef5407
Compare
I'm planning to investigate how to get the module info to the opamp extension, so likely will be looking into this more. |
If we're comfortable relying on the output of this command, we could use it in the Supervisor to relay it to the OpAMP server. That would still be outside OpAMP extension, but at a minimum this will work for the current upstream Collector+OpAMP design. |
Resolves #10570
Alternative to #10598
This implementation is more reliable that #10598 because it gets information directly from the builder manifest. It relies on additional structure in the
component.go
file, ultimately encoded inotelcol.Factories
.An alternative would be to push the enhancements deeper, into the
<kind>.Factories
implementations, so that the module information is available directly alongside the Factory.