Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiverhelper] Update metric units #10657

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

crobert-1
Copy link
Member

Description

1 isn't an informative unit for metrics, this should clarify their units.

Link to tracking issue

Fixes #10650

@crobert-1 crobert-1 requested review from a team and jpkrohling July 17, 2024 23:21
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.38%. Comparing base (43ed618) to head (c610c3c).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10657      +/-   ##
==========================================
+ Coverage   92.32%   92.38%   +0.06%     
==========================================
  Files         397      403       +6     
  Lines       18701    18729      +28     
==========================================
+ Hits        17265    17303      +38     
+ Misses       1076     1066      -10     
  Partials      360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crobert-1

@codeboten codeboten merged commit a09ec93 into open-telemetry:main Jul 22, 2024
52 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review metadata.yaml units for internal telemetry: receiver/receiverhelper
3 participants