-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move extension builder into internal service #10785
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10785 +/- ##
==========================================
+ Coverage 91.67% 91.68% +0.01%
==========================================
Files 408 409 +1
Lines 19164 19192 +28
==========================================
+ Hits 17568 17596 +28
Misses 1237 1237
Partials 359 359 ☔ View full report in Codecov by Sentry. |
Before we break the API, we typically deprecate it for at least one release. More here: https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#breaking-changes |
9931052
to
4da3110
Compare
57a3485
to
e381ee9
Compare
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description There builders were deprecated in 0.108.0, so they can be removed now. PRs that deprecated the builders: * #10781 * #10782 * #10783 * #10784 * #10785 cc @mx-psi
Description
This moves the connector builder out of the
connector
package, and intoservice/internal/builders
.There's no real reason for this struct to be public (folks shouldn't call it), and making it private will allow us to add profiling support to it.
Link to tracking issue
#10375 (review)
While this is not technically required for the profiles work (there is no notion of signals in extensions), this PR is here to keep things consistent.