Enable batch sender in oltpexporter #10846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/easycla |
1 similar comment
|
/easycla |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10846 +/- ##
=======================================
Coverage 91.59% 91.60%
=======================================
Files 404 404
Lines 18983 18990 +7
=======================================
+ Hits 17388 17395 +7
Misses 1235 1235
Partials 360 360 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Dmitrii Anoshin <[email protected]>
|
The failing contrib jobs will be fixed once open-telemetry/opentelemetry-collector-contrib#34721 is merged |
bogdandrutu
approved these changes
Aug 16, 2024
dmitryax
approved these changes
Aug 16, 2024
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Sep 11, 2024
**Description:** Add exportbatcher.BatcherConfig to OTel-Arrow exporter. Follows open-telemetry/opentelemetry-collector#10846 as we intend to maintain parity between OTLP/gRPC and OTel-Arrow exporters. **Link to tracking Issue:** **Testing:** ✅ **Documentation:** README updated with reference to new batcher and [concurrent batch processor](https://github.com/open-telemetry/otel-arrow/tree/main/collector/processor/concurrentbatchprocessor) in the otel-arrow repo. --------- Co-authored-by: Matthew Wear <[email protected]>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…try#34802) **Description:** Add exportbatcher.BatcherConfig to OTel-Arrow exporter. Follows open-telemetry/opentelemetry-collector#10846 as we intend to maintain parity between OTLP/gRPC and OTel-Arrow exporters. **Link to tracking Issue:** **Testing:** ✅ **Documentation:** README updated with reference to new batcher and [concurrent batch processor](https://github.com/open-telemetry/otel-arrow/tree/main/collector/processor/concurrentbatchprocessor) in the otel-arrow repo. --------- Co-authored-by: Matthew Wear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds opt-in support to oltp exporter for the experimental batch sender (#8122). By default batch sender is not enabled.
Similar:
batcherconfig opentelemetry-collector-contrib#34238Link to tracking issue
Resolves #10834
Testing
exporter/otlpexporter/config_test.goDocumentation
Updated the
oltpexporterREADME to point toexporterhelperREADME for batching.