[componentstatus] Add Reporter interface #10852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10852 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 406 406
Lines 19001 19005 +4
=======================================
+ Hits 17414 17418 +4
Misses 1227 1227
Partials 360 360 ☔ View full report in Codecov by Sentry. |
mwear
approved these changes
Aug 13, 2024
mx-psi
approved these changes
Aug 13, 2024
mx-psi
pushed a commit
that referenced
this pull request
Aug 14, 2024
#### Description This is a prep PR to reduce the size of #10777. As part of the work to make our `component.Host` implementation implement `componentstatus.Reporter` (see #10852), the `host` struct and `graph` logic need to be closer together. This is because, as part of #10777 `StartAll` is changed to depend on our specific `Host` type instead of a `component.Host`. Our host already has a dependency on `graph`, so it can't be moved into its own module. <!-- Issue number if applicable --> #### Link to tracking issue Related to #10777 Related to #10413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
Reporterinterface that represents how acomponent.Hostimplementation could expose the ability to report a status.You can see how this interface will be used by looking at Related to #10777
Link to tracking issue
Related to #10777
Related to #10413
Testing
Added unit test