Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add profiles to fanoutconsumer #10946

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Aug 22, 2024

Description

This adds profiles support in fanoutconsumer. That is required to be able to handle profiles in the service graph.
As this is only changing internal modules, I am marking it as chore (and skipping changelog entry).

Link to tracking issue

#10375

cc @mx-psi

@dmathieu dmathieu changed the title chore: Add profiles to fanoutconsumer [chore] Add profiles to fanoutconsumer Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (2971358) to head (2212b7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10946      +/-   ##
==========================================
+ Coverage   91.70%   91.71%   +0.01%     
==========================================
  Files         411      412       +1     
  Lines       19292    19323      +31     
==========================================
+ Hits        17692    17723      +31     
  Misses       1239     1239              
  Partials      361      361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review August 22, 2024 15:04
@dmathieu dmathieu requested review from a team and songy23 August 22, 2024 15:04
@songy23 songy23 requested a review from mx-psi August 22, 2024 17:08
@mx-psi mx-psi added this to the Profiling support milestone Aug 26, 2024
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mx-psi mx-psi merged commit 498c6be into open-telemetry:main Aug 29, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants