[component] Try adding PipelineID #10947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
force-pushed
the
component-datatype-refactor
branch
from
fdf37fe
to
90ac27a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10947 +/- ##
==========================================
- Coverage 92.21% 91.96% -0.26%
==========================================
Files 414 414
Lines 19802 19857 +55
==========================================
Hits 18261 18261
- Misses 1168 1223 +55
Partials 373 373 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
force-pushed
the
component-datatype-refactor
branch
from
90ac27a
to
677abe0
Compare
TylerHelmuth
force-pushed
the
component-datatype-refactor
branch
from
677abe0
to
53afc8f
Compare
TylerHelmuth
force-pushed
the
component-datatype-refactor
branch
3 times, most recently
from
84f16c7
to
636b38e
Compare
TylerHelmuth
force-pushed
the
component-datatype-refactor
branch
from
636b38e
to
0d37132
Compare
This was referenced Sep 17, 2024
mx-psi
pushed a commit
that referenced
this pull request
Sep 20, 2024
#### Description To facilitate the work in #11204 as some breaking changes and some deprecations, this PR adds the new pipeline module separately so that future PRs can handle the breaking changes and deprecations. In order to make `Signal` uninstantiable outside of this repo, while still being extendable in places like `componentprofiles`, a new internal module is added to handle the `Signal` logic. To reduce the dependency sprawl that would happen if `signal` was an internal package in `go.opentelemetry.io/collector`, I made it a module, similar to `globalgates`. <!-- Issue number if applicable --> #### Link to tracking issue Related to #10947 <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests <!--Describe the documentation added.--> #### Documentation Added godoc comments
codeboten
pushed a commit
that referenced
this pull request
Sep 23, 2024
#### Description Depends on #11209 This PR is a non-breaking implementation of #10947. It adds a new module, `pipeline`, which houses a `pipeline.ID` and `pipeline.Signal`. `pipeline.ID` is used to identify a pipeline within the service. `pipeline.Signal` is uses to identify the signal associated to a pipeline. I do this work begrudgingly. As the PR shows, this is a huge refactor when done in a non-breaking way, will require 3 full releases, and doesn't benefit our [End Users or, in my opinion, our Component Developers or Collector Library Users](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#target-audiences). I view this refactor as a Nice-To-Have, not a requirement for Component 1.0. <!-- Issue number if applicable --> #### Link to tracking issue Works towards #9429
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Sep 24, 2024
…emetry#11204) #### Description Depends on open-telemetry#11209 This PR is a non-breaking implementation of open-telemetry#10947. It adds a new module, `pipeline`, which houses a `pipeline.ID` and `pipeline.Signal`. `pipeline.ID` is used to identify a pipeline within the service. `pipeline.Signal` is uses to identify the signal associated to a pipeline. I do this work begrudgingly. As the PR shows, this is a huge refactor when done in a non-breaking way, will require 3 full releases, and doesn't benefit our [End Users or, in my opinion, our Component Developers or Collector Library Users](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#target-audiences). I view this refactor as a Nice-To-Have, not a requirement for Component 1.0. <!-- Issue number if applicable --> #### Link to tracking issue Works towards open-telemetry#9429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another investigation into #9429 based on this strategy.
If we like this approach I can add in the
Must*functions to enforce pipeline name patterns. It also doesn't really matter wherePipelineIDorSignallive, butcomponentstatusdepends onPipelineIDso it can't live inservice.Breaking changes in:
componentstatus:component.ID->component.PipelineIDcomponentprofiles:DataTypeProfiles->SignalProfilesexporter.exporterqueue.Settings.DataType:component.DataType->component.Signalservice.pipelines.Config:component.ID->component.PipelineIDexporter.exportertest.CheckConsumeContractParams:component.DataType->component.Signalconnector.LogsRouterAndConsumer.Consumer:component.ID->component.PipelineIDconnector.LogsRouterAndConsumer.PipelineIDs:component.ID->component.PipelineIDconnector.NewLogsRouter:component.ID->component.PipelineIDconnector.MetricsRouterAndConsumer.Consumer:component.ID->component.PipelineIDconnector.MetricsRouterAndConsumer.PipelineIDs:component.ID->component.PipelineIDconnector.NewMetricsRouter:component.ID->component.PipelineIDconnector.TracesRouterAndConsumer.Consumer:component.ID->component.PipelineIDconnector.TracesRouterAndConsumer.PipelineIDs:component.ID->component.PipelineIDconnector.NewTracesRouter:component.ID->component.PipelineID