Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles support in OTLP receiver #11071

Merged
merged 19 commits into from
Sep 17, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Sep 6, 2024

Description

This adds profiles support to the OTLP receiver.

cc @mx-psi

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 88.76404% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.84%. Comparing base (792a401) to head (9d6d9f9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
receiver/otlpreceiver/otlphttp.go 60.00% 5 Missing and 3 partials ⚠️
receiver/otlpreceiver/factory.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11071      +/-   ##
==========================================
- Coverage   91.86%   91.84%   -0.02%     
==========================================
  Files         413      415       +2     
  Lines       19766    19850      +84     
==========================================
+ Hits        18158    18232      +74     
- Misses       1239     1245       +6     
- Partials      369      373       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review September 6, 2024 17:28
@dmathieu dmathieu requested review from a team and songy23 September 6, 2024 17:28
@songy23 songy23 requested a review from mx-psi September 6, 2024 17:29
@mx-psi
Copy link
Member

mx-psi commented Sep 11, 2024

I think we should wait until open-telemetry/opentelemetry-proto#582 is merged (I don't mind if it's merged but not released, but I would like some sort of consensus)

@mx-psi mx-psi added this to the Profiling support milestone Sep 12, 2024
@mx-psi
Copy link
Member

mx-psi commented Sep 17, 2024

@dmathieu Can you fix the merge conflicts? I can merge after that

@dmathieu
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants