Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix flaky Test_ComponentStatusReporting_SharedInstance test #11078

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

TylerHelmuth
Copy link
Member

Description

Try adding wait group to ensure StatusOk is reported before the call to Shutdown.

Passed with go test status_test.go --count 2000

Link to tracking issue

Fixes #10927

@TylerHelmuth TylerHelmuth requested review from a team and dmitryax September 6, 2024 18:38
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (ec5d94a) to head (3084e87).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11078   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         414      414           
  Lines       19718    19718           
=======================================
  Hits        18183    18183           
  Misses       1165     1165           
  Partials      370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit e2aaa77 into open-telemetry:main Sep 6, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky test] Test_ComponentStatusReporting_SharedInstance flaky
3 participants