[processorhelper] deprecate additional obsreport funcs #11145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions were only used in one processor in both core and contrib. Moving the metrics directly to that processor and deprecating the processorhelper funcs for now. Signed-off-by: Alex Boten <[email protected]>
|
Alternative to #11114 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11145 +/- ##
==========================================
- Coverage 92.28% 92.26% -0.02%
==========================================
Files 414 414
Lines 19798 19802 +4
==========================================
Hits 18270 18270
- Misses 1156 1160 +4
Partials 372 372 ☔ View full report in Codecov by Sentry. |
djaglowski
approved these changes
Sep 13, 2024
|
Replaced by #11201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions were only used in one processor in both core and contrib. Moving the metrics directly to that processor and deprecating the processorhelper funcs for now.