[Chore] Migration error and helper into scraper model #11166
+1,815
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzk1
commented
Sep 13, 2024
receiver/scraper/helper/internal/metadata/generated_telemetry.go
Outdated
Show resolved
Hide resolved
|
cc @mx-psi plta. |
mx-psi
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Thanks for the PR! This is a good start, I have two comments:
- Can we keep the original names (
scraperhelper,scrapererror)? When importing, Go will only use the package name, so we tend to repeat the parent package name if the name is not specific - To help in the transition, we should keep the original
scraperpackages for one release as documented here: https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#breaking-changes. To do this, you can have a type alias for each symbol like this:
type ScrapeFunc = scraperhelper.ScrapeFuncWe then can deprecate the whole package as mentioned here https://go.dev/wiki/Deprecated#examples
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11166 +/- ##
==========================================
+ Coverage 91.79% 91.86% +0.06%
==========================================
Files 432 438 +6
Lines 20426 20645 +219
==========================================
+ Hits 18751 18965 +214
- Misses 1301 1302 +1
- Partials 374 378 +4 ☔ View full report in Codecov by Sentry. |
|
Looks like this needs a |
mx-psi
approved these changes
Oct 7, 2024
bogdandrutu
reviewed
Oct 14, 2024
| @@ -0,0 +1 @@ | |||
| include ../../Makefile.Common | |||
There was a problem hiding this comment.
Suggested change
| include ../../Makefile.Common | |
| include ../../Makefile.Common | |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move helper and error packages into scraper module.
Link to tracking issue
Fixes #11003
Testing
Documentation